Skip to content

fs: cache context lookup in vectored io loops #61387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mertcanaltin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fs: cache context lookup in vectored io loops #61387

mertcanaltin wants to merge 2 commits into from
+5 −4

Conversation

@mertcanaltin
Copy link
Member

@mertcanaltin mertcanaltin commented Jan 14, 2026

I tried to prevent the call from being repeated

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (903f647) to head (77c67fd).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61387      +/-   ##
==========================================
- Coverage   88.54%   88.51%   -0.03%     
==========================================
  Files         704      704              
  Lines      208793   208797       +4     
  Branches    40307    40315       +8     
==========================================
- Hits       184866   184810      -56     
- Misses      15913    15966      +53     
- Partials     8014     8021       +7
Files with missing lines Coverage Δ
src/node_realm-inl.h 88.67% <100.00%> (+0.44%) ⬆️
src/node_realm.cc 74.85% <ø> (-0.30%) ⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax
addaleax approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also move Realm::context() into node_realm-inl.h so that the compiler can already make this optimization itself.

@mertcanaltin
Copy link
Member Author

mertcanaltin commented Jan 15, 2026

You can also move Realm::context() into node_realm-inl.h so that the compiler can already make this optimization itself.

thanks, I used

@mertcanaltin mertcanaltin requested a review from addaleax January 15, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax Awaiting requested review from addaleax

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mertcanaltin @addaleax @nodejs-github-bot